----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7293/#review12004 -----------------------------------------------------------
src/tests/utils.hpp <https://reviews.apache.org/r/7293/#comment25575> fits on one line src/tests/utils.hpp <https://reviews.apache.org/r/7293/#comment25581> can we kill the outside do-while(false) and just replace it with braces? src/tests/utils.hpp <https://reviews.apache.org/r/7293/#comment25578> make sleeps unsigned? src/tests/utils.hpp <https://reviews.apache.org/r/7293/#comment25579> let's use braces here for consistency? src/tests/utils.hpp <https://reviews.apache.org/r/7293/#comment25576> this file should include <unistd.h> for usleep - Ben Mahler On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7293/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (5 of 7). > > > Diffs > ----- > > src/tests/utils.hpp fc2023b > src/tests/zookeeper_tests.cpp 2e04069 > > Diff: https://reviews.apache.org/r/7293/diff/ > > > Testing > ------- > > This added test is EXPECTED to fail. > > > Thanks, > > Benjamin Hindman > >
