> On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote: > > src/tests/utils.hpp, line 628 > > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line628> > > > > fits on one line
Done. > On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote: > > src/tests/utils.hpp, line 634 > > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line634> > > > > can we kill the outside do-while(false) and just replace it with braces? Using the do while () makes this a statement rather than just a block, so it can be used in more places. > On Sept. 27, 2012, 9:45 p.m., Ben Mahler wrote: > > src/tests/utils.hpp, line 638 > > <https://reviews.apache.org/r/7293/diff/1/?file=160213#file160213line638> > > > > let's use braces here for consistency? Great, thanks! - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7293/#review12004 ----------------------------------------------------------- On Sept. 26, 2012, 6:01 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7293/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2012, 6:01 p.m.) > > > Review request for mesos, John Sirois, Vinod Kone, and Ben Mahler. > > > Description > ------- > > See summary (5 of 7). > > > Diffs > ----- > > src/tests/utils.hpp fc2023b > src/tests/zookeeper_tests.cpp 2e04069 > > Diff: https://reviews.apache.org/r/7293/diff/ > > > Testing > ------- > > This added test is EXPECTED to fail. > > > Thanks, > > Benjamin Hindman > >
