----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7185/#review12233 -----------------------------------------------------------
third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7185/#comment25959> I dont think you need another !isReady() here. third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7185/#comment25960> what about discarded? third_party/libprocess/include/stout/result.hpp <https://reviews.apache.org/r/7185/#comment25961> s/Result/Result: / third_party/libprocess/include/stout/try.hpp <https://reviews.apache.org/r/7185/#comment25963> s/Try in ERROR:/ERROR Try:/ to be consistent - Vinod Kone On Oct. 8, 2012, 6:26 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7185/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 6:26 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See above. > > > Diffs > ----- > > third_party/libprocess/include/process/future.hpp bb0e366 > third_party/libprocess/include/stout/result.hpp f6b92a0 > third_party/libprocess/include/stout/try.hpp e865924 > > Diff: https://reviews.apache.org/r/7185/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
