----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7185/#review12249 -----------------------------------------------------------
Ship it! Thanks Ben! third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7185/#comment25990> Add a CHECK(!isPending()) here first, since this is our bug. Then check isFailed and isDiscarded as you've done. third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7185/#comment25991> Future::get() and s/Future/future/ third_party/libprocess/include/process/future.hpp <https://reviews.apache.org/r/7185/#comment25992> Ditto. third_party/libprocess/include/stout/result.hpp <https://reviews.apache.org/r/7185/#comment25993> What about: "Result::get() but state == ERROR:" Same above for Future (and below for Try). - Benjamin Hindman On Oct. 8, 2012, 7:47 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7185/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2012, 7:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > see above > > > Diffs > ----- > > third_party/libprocess/include/process/future.hpp > bb0e366b82d227cafd171d98013bd84045fba257 > third_party/libprocess/include/stout/result.hpp > f6b92a0631a39a9d1fc33466eb868e05028a3928 > third_party/libprocess/include/stout/try.hpp > e865924296633591af3c37b1e4aa3ba52955f199 > > Diff: https://reviews.apache.org/r/7185/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
