-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7544/#review12335
-----------------------------------------------------------



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/7544/#comment26112>

    Docs here would be great.



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/7544/#comment26111>

    why not inline this in the next line?



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/7544/#comment26113>

    s/no/not/



third_party/libprocess/src/process.cpp
<https://reviews.apache.org/r/7544/#comment26115>

    fits in one line



third_party/libprocess/src/tests.cpp
<https://reviews.apache.org/r/7544/#comment26116>

    why not use a trigger here instead?


- Vinod Kone


On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7544/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2012, 7:48 a.m.)
> 
> 
> Review request for mesos, Vinod Kone and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/src/process.cpp 
> fde7154f9a4432acaff09849c0fa69c0694c9834 
>   third_party/libprocess/src/tests.cpp 
> 1cb26cd1729ce1cf0ed9573d3eb40690705d4b4e 
> 
> Diff: https://reviews.apache.org/r/7544/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to