> On Oct. 11, 2012, 5:51 p.m., Vinod Kone wrote: > > third_party/libprocess/src/process.cpp, line 1577 > > <https://reviews.apache.org/r/7544/diff/1/?file=175698#file175698line1577> > > > > why not inline this in the next line?
This was the style in this code base, so I kept it consistent. > On Oct. 11, 2012, 5:51 p.m., Vinod Kone wrote: > > third_party/libprocess/src/tests.cpp, line 1153 > > <https://reviews.apache.org/r/7544/diff/1/?file=175699#file175699line1153> > > > > why not use a trigger here instead? Triggers are Mesos specific things, and don't exist in libprocess. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7544/#review12335 ----------------------------------------------------------- On Oct. 11, 2012, 7:48 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7544/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2012, 7:48 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > third_party/libprocess/src/process.cpp > fde7154f9a4432acaff09849c0fa69c0694c9834 > third_party/libprocess/src/tests.cpp > 1cb26cd1729ce1cf0ed9573d3eb40690705d4b4e > > Diff: https://reviews.apache.org/r/7544/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
