----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7658/#review12616 -----------------------------------------------------------
src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment26927> s/CHECK/CHECK./ src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment26929> kill line src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment26932> how do you like 'current' instead of 'latest'? i think that's more idiomatic? src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment26930> s/mkdir/symlink/ src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment26931> s/mkdir/symlink/ src/slave/state.hpp <https://reviews.apache.org/r/7658/#comment26933> Can you please add a TODO(vinod) here for keeping track of latest. src/slave/state.cpp <https://reviews.apache.org/r/7658/#comment26934> you need to ignore 'latest' when you loop through all runs here. foreach (const string& path, runs.get()) { //TODO(vinod): Store latest UUID in the state. if (path == "latest") { continue; } } src/tests/slave_state_tests.cpp <https://reviews.apache.org/r/7658/#comment26936> Why not use 'createExecutorWorkDirectory'? third_party/libprocess/include/stout/fs.hpp <https://reviews.apache.org/r/7658/#comment26937> thank you :) third_party/libprocess/include/stout/fs.hpp <https://reviews.apache.org/r/7658/#comment26938> kill line - Vinod Kone On Oct. 19, 2012, 12:46 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7658/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2012, 12:46 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This replaces our run directory numbers with the executor uuids. > > Ex: > .../executorFoo/runs/0 > .../executorFoo/runs/1111-1111-1111-1111 > > This ensures we don't ever write to an old directory that was gc'ed. > > > Diffs > ----- > > src/slave/paths.hpp 48a7be0ae33785206ebb1985647178224d6bcfb8 > src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 > src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c > src/slave/state.hpp dcadd511063584cde51f533e2120f4eab5145fd2 > src/slave/state.cpp c8406fbb5586bca5b7f169a2ef937c958626dee1 > src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f > third_party/libprocess/include/stout/fs.hpp > 1516d0b6fa6e0ced26bb08ab6a4fadf28232124f > > Diff: https://reviews.apache.org/r/7658/diff/ > > > Testing > ------- > > Updated tests + make check. > > > Thanks, > > Ben Mahler > >
