----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7658/#review12724 -----------------------------------------------------------
Ship it! src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment27119> I've tried to just include "logging/logging.hpp" instead of glog explicitly. I do this in the event we add other logging abstractions I'd rather just include a single thing. Just FYI. src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment27118> We include stout as though it's an external library (because it really is), so using <> instead of "". src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment27120> I think wrapping stuff like this to all fit on the newline is easier to read. src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment27124> Hmm, maybe we shouldn't jump the gun with conclusions here and just print the error. Why were you thinking the possible hypothesis would be useful? src/slave/paths.hpp <https://reviews.apache.org/r/7658/#comment27123> -2 src/slave/slave.hpp <https://reviews.apache.org/r/7658/#comment27135> -2 src/slave/slave.cpp <https://reviews.apache.org/r/7658/#comment27137> Please include a brief comment about why you are creating a UUID. src/tests/slave_state_tests.cpp <https://reviews.apache.org/r/7658/#comment27136> Same thing for including stout here, not sure why I missed this in a previous review. third_party/libprocess/include/stout/fs.hpp <https://reviews.apache.org/r/7658/#comment27138> I like 'original' and 'link' better than 'path1' and 'path2'. ;) - Benjamin Hindman On Oct. 22, 2012, 7:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7658/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2012, 7:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > This replaces our run directory numbers with the executor uuids. > > Ex: > .../executorFoo/runs/0 > .../executorFoo/runs/1111-1111-1111-1111 > > This ensures we don't ever write to an old directory that was gc'ed. > > > Diffs > ----- > > src/slave/paths.hpp 48a7be0ae33785206ebb1985647178224d6bcfb8 > src/slave/slave.hpp 343c353027dbd2a7c1be8cee99a1d59367169177 > src/slave/slave.cpp 5af7464aae17c00a0e707421982d7cb055aabc6c > src/slave/state.hpp dcadd511063584cde51f533e2120f4eab5145fd2 > src/slave/state.cpp c8406fbb5586bca5b7f169a2ef937c958626dee1 > src/tests/slave_state_tests.cpp 0e232ff3ed773f3bdccc05e716b66d106d80fb2f > third_party/libprocess/include/stout/fs.hpp > 1516d0b6fa6e0ced26bb08ab6a4fadf28232124f > > Diff: https://reviews.apache.org/r/7658/diff/ > > > Testing > ------- > > Updated tests + make check. > > > Thanks, > > Ben Mahler > >
