> On Oct. 18, 2012, 1:25 a.m., Vinod Kone wrote:
> > src/linux/cgroups.cpp, line 723
> > <https://reviews.apache.org/r/7620/diff/1/?file=177249#file177249line723>
> >
> >     this is a cpp, so why not just do 'using std::string' at the top.

I agree, cleaned this up, thanks for the nudge!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7620/#review12553
-----------------------------------------------------------


On Oct. 24, 2012, 4:40 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7620/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 4:40 a.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp f0e343d9348075484fa5a4be739a5cef8b9dea21 
>   src/linux/cgroups.cpp 58e9fec193cf0da39fdbee3ee1891fd716a63bbb 
>   third_party/libprocess/include/stout/path.hpp 
> e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b 
> 
> Diff: https://reviews.apache.org/r/7620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Reply via email to