Re: Review Request: Added cgroups::hierarchies to list the currently active hierarchies and cgroups::internal::cloneCpusetValues in order to copy cpuset.cpus and cpuset.mems from a parent to a child cgroup. Also updated code to use path::join as appropriate.

[Ben Mahler]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7620/#review12726
-----------------------------------------------------------

Ship it!


Cosmetics, so pending my comments, looks good.


src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27125>

    1. Maybe let's verify that it's a relative path?
    
    Oh I see, so passing in "foo" or "/foo" will consider the parent to be "/", 
or, the "root" of the heirarchy:
    
    /heirarchy//
    
    



third_party/libprocess/include/stout/path.hpp
<https://reviews.apache.org/r/7620/#comment27126>

    How about:
    
    join(path1, join(path2, path3, path4));
    
    Either in this or the subsequent path::join review you sent out.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27127>

    Restore the comment alignment.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27128>

    I'd prefer this visually if you killed the newlines between the
    
    Try cpu = ...;
    
    if (cpu.isError()) {
    ...
    }
    
    to become:
    
    Try cpu = ...;
    if (cpu.isError()) {
    ...
    }
    
    In all the error checks in this function, it makes each logical chunk more 
obvious IMO.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27129>

    Kill newline?



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27131>

    Is jie's TODO here still applicable?
    
    



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27132>

    ditto.



src/linux/cgroups.cpp
<https://reviews.apache.org/r/7620/#comment27134>

    Not yours but:
    
    s/walk/walk: /
    
    Also looks like this fits on one line.


- Ben Mahler


On Oct. 24, 2012, 4:40 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7620/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2012, 4:40 a.m.)
> 
> 
> Review request for mesos, Vinod Kone, Jie Yu, and Ben Mahler.
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/linux/cgroups.hpp f0e343d9348075484fa5a4be739a5cef8b9dea21 
>   src/linux/cgroups.cpp 58e9fec193cf0da39fdbee3ee1891fd716a63bbb 
>   third_party/libprocess/include/stout/path.hpp 
> e64f8a01d004c5e6513880ed2a1a85d4ec4f9e8b 
> 
> Diff: https://reviews.apache.org/r/7620/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>