----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7719/#review12731 -----------------------------------------------------------
src/tests/allocator_tests.cpp <https://reviews.apache.org/r/7719/#comment27142> Please revert. The former is def clearer and tells me that this is a test/mock filter. src/tests/gc_tests.cpp <https://reviews.apache.org/r/7719/#comment27141> why was this removed from the fixture? - Vinod Kone On Oct. 24, 2012, 4:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7719/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2012, 4:57 a.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/java/jni/org_apache_mesos_Log.cpp > 4f27d3ff76c172ab1d3ff6b804bb65e9256ee637 > src/log/coordinator.hpp 01905da7558b1ec8f6d50c5e381dc0ec25c69cc9 > src/log/coordinator.cpp 134e655c6211eba189375ed9697d31f5d60decd0 > src/log/log.hpp ac7aad2dac646a726d4cdecae86c949c9865d917 > src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a > src/tests/allocator_zookeeper_tests.cpp > bd408c22df5edc3684791e509ce1a4c210553922 > src/tests/exception_tests.cpp f99c92045c68676991fec61f7613c804eaffaad6 > src/tests/fault_tolerance_tests.cpp > 558bf41ab6f4ba319ec3b23f3347f98e235260f9 > src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e > src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e > src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452 > src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b > > Diff: https://reviews.apache.org/r/7719/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
