----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7719/ -----------------------------------------------------------
(Updated Oct. 26, 2012, 5 p.m.) Review request for mesos, Vinod Kone and Ben Mahler. Changes ------- Made EXPECT_MESSAGE be even more high-level (no need to pass in a Filter instance now) and added test listeners to make sure the filter is always unset. Summary (updated) ----------------- Refactored the libprocess test "filter" so that tests only need to use EXPECT_MESSAGE(from, to, body) and no longer need to explicitly construct, set, unset, or destruct an actual filter instance. Description ------- See summary. Diffs (updated) ----- src/Makefile.am cf9364ea0418ec30a75b1774f32bda8de6e031ac src/java/jni/org_apache_mesos_Log.cpp 4f27d3ff76c172ab1d3ff6b804bb65e9256ee637 src/log/coordinator.hpp 01905da7558b1ec8f6d50c5e381dc0ec25c69cc9 src/log/coordinator.cpp 134e655c6211eba189375ed9697d31f5d60decd0 src/log/log.hpp ac7aad2dac646a726d4cdecae86c949c9865d917 src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a src/tests/allocator_zookeeper_tests.cpp bd408c22df5edc3684791e509ce1a4c210553922 src/tests/environment.cpp PRE-CREATION src/tests/exception_tests.cpp f99c92045c68676991fec61f7613c804eaffaad6 src/tests/fault_tolerance_tests.cpp 558bf41ab6f4ba319ec3b23f3347f98e235260f9 src/tests/filter.hpp PRE-CREATION src/tests/filter.cpp PRE-CREATION src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e src/tests/log_tests.cpp 26aa9dda5e95f3235fff83970978fe79247ada3e src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452 src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b Diff: https://reviews.apache.org/r/7719/diff/ Testing ------- make check Thanks, Benjamin Hindman
