----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7720/#review12833 -----------------------------------------------------------
Is this the latest diff? - Ben Mahler On Oct. 25, 2012, 1:58 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7720/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2012, 1:58 a.m.) > > > Review request for mesos, Benjamin Hindman, Thomas Marshall, and Ben Mahler. > > > Description > ------- > > Specifically: > > --> Allocator writers don't need to do extra work to make their allocator > async. This is guaranteed/enforced by the Allocator interface. > > --> Inside master, the allocator calls looks like method calls instead of > dispatches. > > > Diffs > ----- > > src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798 > src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac > src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831 > src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4 > src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d > src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5 > src/master/hierarchical_allocator_process.hpp > 266d339bdb72f8c63288d91c1f514da07ee9acf2 > src/master/main.cpp 813ef7de8e57b1cbd688e6e34e360c7b191ed641 > src/master/master.hpp 146af017bbb6da9bd44acb53a4f1ee0ffbedd64f > src/master/master.cpp 82e4dc704e5c67ec178bd058934896328308d868 > src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d > src/sched/sched.cpp 5a4e594a3a8a2089cf74e7e418f2e7bde4c03e9d > src/tests/allocator_tests.cpp ed52ff61b1820cb3f5f7f2ae421fb3f84a85939a > src/tests/allocator_zookeeper_tests.cpp > bd408c22df5edc3684791e509ce1a4c210553922 > src/tests/fault_tolerance_tests.cpp > 558bf41ab6f4ba319ec3b23f3347f98e235260f9 > src/tests/gc_tests.cpp 1de240579a1cc6af8738d2ffb5da1b3e01c4b19e > src/tests/master_detector_tests.cpp > fb32af8130d3f359eecba5389c2e42c247d6b70e > src/tests/master_tests.cpp 37e97e0a58a0128579f155183b7e769ab4e1b452 > src/tests/resource_offers_tests.cpp > c50da38508694f956ad104fb160896eb9b9d5fea > src/tests/utils.hpp 4066c02b23db15310104955465c4e4afd7bcad5b > > Diff: https://reviews.apache.org/r/7720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
