----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7720/#review13233 -----------------------------------------------------------
Ship it! src/master/allocator.hpp <https://reviews.apache.org/r/7720/#comment28464> s/return // src/sched/sched.cpp <https://reviews.apache.org/r/7720/#comment28462> s/the// src/sched/sched.cpp <https://reviews.apache.org/r/7720/#comment28463> Ditto. src/tests/allocator_tests.cpp <https://reviews.apache.org/r/7720/#comment28461> Kill. src/tests/allocator_zookeeper_tests.cpp <https://reviews.apache.org/r/7720/#comment28460> Kill this. src/tests/utils.hpp <https://reviews.apache.org/r/7720/#comment28466> It's probably time to split this out from utils.hpp, this file has too much stuff in it. - Benjamin Hindman On Nov. 6, 2012, 8:10 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/7720/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2012, 8:10 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Refactored Allocator. > > Features: > > --> Master can make direct method calls on the Allocator instead of doing > dipatches. > > --> MockAllocatorProcess does dispatches to the underlying allocator process > instead of directly invoking the methods. > > > Diffs > ----- > > src/Makefile.am 062c45c060c67e983d0c27770eb3f1eefd582c8f > src/local/local.hpp cd0483c72f919e08a67b4eeaebef3b62b0ff9798 > src/local/local.cpp 67c7a7c260d2ea610fb64b491f9bf7a22ec53aac > src/master/allocator.hpp 9fd790564d1361b9bdb2111f29348a631f66c831 > src/master/allocator.cpp 3f822912a4e0c50c1612eac98ae85447aae023d4 > src/master/drf_sorter.hpp 9c43ba32c6ed04fd6960524b5925c5c27c3e4d2d > src/master/drf_sorter.cpp 0ab4a14ca0bfb721de00e29d993fd4aa08a27ac5 > src/master/hierarchical_allocator_process.hpp > 266d339bdb72f8c63288d91c1f514da07ee9acf2 > src/master/main.cpp 74c955f262179d52408d6b0eaada4d7801bcc193 > src/master/master.hpp 1d8d0e4b0080d5efb25f8140e4a9bafdff513469 > src/master/master.cpp 8b6c71575d57816588a52dfc0fa74e51df1bea4d > src/master/sorter.hpp 80d0893b1f988898e40ae3a2f6f19a117ad5f72d > src/sched/sched.cpp 6f190e9f86d2ecdcfed8ec06831940606332e536 > src/tests/allocator_tests.cpp b0056b983b3a604e9124306cb12a366e5896a588 > src/tests/allocator_zookeeper_tests.cpp > 72ec292cf5a85d2012d940a347293ef105206ef1 > src/tests/fault_tolerance_tests.cpp > a01d1aef012b636f2ced64d4d2ffabfb6ce42644 > src/tests/gc_tests.cpp b61b2de621e227f327ce546b62f8dfc528f3894e > src/tests/master_detector_tests.cpp > c0dc301f2a9f8d586864794c0526caac6c68727e > src/tests/master_tests.cpp 7112c8c877eb4d852c36d65a7d44af74652239b3 > src/tests/resource_offers_tests.cpp > 9f7916873423382443f39c31b1d682dc0e4071bb > src/tests/utils.hpp e0036c04bef60d62cc4314a7e0beb02a0071a808 > > Diff: https://reviews.apache.org/r/7720/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
