> On Nov. 15, 2012, 9:58 p.m., Vinod Kone wrote: > >
thanks! > On Nov. 15, 2012, 9:58 p.m., Vinod Kone wrote: > > third_party/libprocess/include/stout/json.hpp, line 120 > > <https://reviews.apache.org/r/8056/diff/1/?file=189961#file189961line120> > > > > s/are also escaping/also escape/ > > > > s/we're not encode/ we don't escape/ fixed - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8056/#review13488 ----------------------------------------------------------- On Nov. 14, 2012, 10:16 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8056/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 10:16 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > At twitter, we had an executor using binary data in the TaskInfo.data field. > Since we can't encode unicode / binary data, this breaks the JSON endpoint > and the webui. > > This fixes the break, as well as allows browsing binary files in the webui > (however, encoded as ASCII). > > > Diffs > ----- > > src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666 > third_party/libprocess/include/process/http.hpp > f8d0a5886c77eaf885732346b89be326e89afad6 > third_party/libprocess/include/stout/json.hpp > 1c66dfd324619222f4ed168b7cf18e8f5e558b23 > > Diff: https://reviews.apache.org/r/8056/diff/ > > > Testing > ------- > > make check + added json test > > > Thanks, > > Ben Mahler > >
