----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8056/#review14761 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Hindman On Dec. 19, 2012, 7:02 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8056/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2012, 7:02 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > At twitter, we had an executor using binary data in the TaskInfo.data field. > Since we can't encode unicode / binary data, this breaks the JSON endpoint > and the webui. > > This fixes the break, as well as allows browsing binary files in the webui > (however, encoded as ASCII). > > > This addresses bug MESOS-274. > https://issues.apache.org/jira/browse/MESOS-274 > > > Diffs > ----- > > src/tests/stout_tests.cpp efdb47f1d2401f9175a05fc65922d9ab7e383666 > third_party/libprocess/include/process/http.hpp > ced8c1ab69952c4297d92b472f8d3edb5954105c > third_party/libprocess/include/stout/json.hpp > 1c66dfd324619222f4ed168b7cf18e8f5e558b23 > third_party/libprocess/src/tests.cpp > 131154abc920fa3904b7fa79faedb63f8d593793 > > Diff: https://reviews.apache.org/r/8056/diff/ > > > Testing > ------- > > make check + added json test > > > Thanks, > > Ben Mahler > >
