----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8058/#review13483 -----------------------------------------------------------
src/linux/cgroups.hpp <https://reviews.apache.org/r/8058/#comment28892> So this one is called 'kill' but it's for sending arbitrary signals to all processes in a cgroup? Do we enforce the signal is of type SIGKILL, SIGQUIT, etc.? src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28901> Hm.. this is kind of a backwards way to do error handling compared to how we do it everywhere else. Why the switch from Try<Nothing> to Option<string>? src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28905> ditto src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28907> ditto here and all verify() calls. src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28926> thanks src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28930> great! src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28931> too bad CHECK_SOME is not yet available for all these guys - Ben Mahler On Nov. 14, 2012, 11:57 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8058/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 11:57 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.hpp 1351134dc8b40fb7d7d692c4dd24f0efa24eadb0 > src/linux/cgroups.cpp 039e2b4121edc419e9f1a48a7c0b99ca77aa44ff > src/slave/cgroups_isolation_module.cpp > 8211618d7729350654e2d17946c5b912ed9dda6a > src/tests/assert.hpp 62fde12fa7ddddbbc9e8812f26314af5307a02df > src/tests/cgroups_tests.cpp 85e81854a6767bad5c19f6411130d154c2870d99 > > Diff: https://reviews.apache.org/r/8058/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
