----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8058/#review13491 -----------------------------------------------------------
src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28932> s/recursively create/create recursively src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28940> i think 'freeze cgroup' is more clear. why did you remove? src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28941> ditto src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28943> sounds like this should be a CHECK? src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28944> ditto src/linux/cgroups.cpp <https://reviews.apache.org/r/8058/#comment28945> CHECK? src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28950> unfortunately this is going to conflict with my recent changes in this file :/ src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28946> s/on/in/ ? src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28948> i feel like checking for nest cgroup support should be part of the cgroup library? src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28947> s/, your/. Your/ src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8058/#comment28949> Wait, so were actually disabling the kernel OOM killer? I thought we couldn't escape the first OOM kill by the kernel? src/tests/assert.hpp <https://reviews.apache.org/r/8058/#comment28952> thanks you - Vinod Kone On Nov. 14, 2012, 11:57 p.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8058/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2012, 11:57 p.m.) > > > Review request for mesos, Vinod Kone and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/cgroups.hpp 1351134dc8b40fb7d7d692c4dd24f0efa24eadb0 > src/linux/cgroups.cpp 039e2b4121edc419e9f1a48a7c0b99ca77aa44ff > src/slave/cgroups_isolation_module.cpp > 8211618d7729350654e2d17946c5b912ed9dda6a > src/tests/assert.hpp 62fde12fa7ddddbbc9e8812f26314af5307a02df > src/tests/cgroups_tests.cpp 85e81854a6767bad5c19f6411130d154c2870d99 > > Diff: https://reviews.apache.org/r/8058/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
