> On Nov. 19, 2012, 11:37 p.m., Ben Mahler wrote: > > src/slave/process_based_isolation_module.hpp, line 91 > > <https://reviews.apache.org/r/8077/diff/3/?file=221889#file221889line91> > > > > s/'killExecutor'/killExecutor() ?
done > On Nov. 19, 2012, 11:37 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 1168 > > <https://reviews.apache.org/r/8077/diff/3/?file=221893#file221893line1168> > > > > Where are the schedule and detroyExecutor calls now? Will they be > > called as a consequence of killExecutor? We only do it once now, inside executorTerminated(). And yes killExecutor results in executorTerminated. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8077/#review13596 ----------------------------------------------------------- On Nov. 19, 2012, 9:23 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8077/ > ----------------------------------------------------------- > > (Updated Nov. 19, 2012, 9:23 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This paves the way for a slave to shutdown executors that are not responsive > during launch (e.g. HDFS hang during fetching executor). > > This fix is not enough for cgroups isolation module (enough for the process > based isolation module) because it currently blocks while launching an > executor. > > > This addresses bug MESOS-310. > https://issues.apache.org/jira/browse/MESOS-310 > > > Diffs > ----- > > src/master/hierarchical_allocator_process.hpp > 5bcbeb99c823c3dbca0f89e19473b943c7469dab > src/master/master.cpp 87fad0ed1eaecd59f2814d3e776b746b754b79b7 > src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c > src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 > src/slave/process_based_isolation_module.hpp > efe59ebc0e8120926ea9f36b9eaa2f0b25830faf > src/slave/process_based_isolation_module.cpp > 16fd584e78db2c517d828f2576ab8a38c5ce57ad > src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 > src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba > src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed > > Diff: https://reviews.apache.org/r/8077/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
