My 'ship it' stands, unless there's anything else you think needs more reviewing.
On Mon, Mar 4, 2013 at 1:51 PM, Vinod Kone <[email protected]> wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8077/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 9:51 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Changes > ------- > > Rebased off of "Properly cleanup cgroups" https://reviews.apache.org/r/9408/. > > > Summary (updated) > ----------------- > > Added registration timeout for executors. > > > Description > ------- > > This paves the way for a slave to shutdown executors that are not responsive > during launch (e.g. HDFS hang during fetching executor). > > This fix is not enough for cgroups isolation module (enough for the process > based isolation module) because it currently blocks while launching an > executor. > > > This addresses bug MESOS-310. > https://issues.apache.org/jira/browse/MESOS-310 > > > Diffs (updated) > ----- > > src/master/hierarchical_allocator_process.hpp > 33e059c10bb87db88b1fb9a100b7504bc89ac896 > src/master/master.cpp 814a6e1af2c7caf77452748dfc9e6935d8386d8f > src/slave/cgroups_isolation_module.hpp > a04fc46b15d2741886f5847cadbdc9bed351c588 > src/slave/constants.hpp dc5b9877e2608f6806f13b6ef4d133b6fddaece4 > src/slave/constants.cpp ecb96fd42afdb74aca394411c6ff60276f509cfd > src/slave/process_based_isolation_module.hpp > 6a4e6aef9ab4b13cce9341f6f35c6b24e6f8fde7 > src/slave/process_based_isolation_module.cpp > ff98d105af675dfc66070feaa43b42c1aa438fd8 > src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 > src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 > src/slave/slave.cpp c13d268c5e0e107902f64e30304a18128927a571 > src/tests/master_tests.cpp 104610cef3fdaaea75271657c42c4fd2b6b61618 > third_party/libprocess/include/process/delay.hpp > cb2fa9ab372e62befec01a95b3ca401567a1a626 > > Diff: https://reviews.apache.org/r/8077/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone >
