----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8239/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone. Description ------- We were not validating executor resources, some executors would request 0 cpus and 0 memory. This would result in an OOM (if using the memory subsystem) or cpuset.cpus errors (if using the cpuset subsystem, we would write nothing to the cpuset.cpus file. This results in a write error: "No space left on device."). Diffs ----- src/examples/balloon_framework.cpp 35bc0fe712edbf6130e10e93286c5278625be096 src/examples/java/TestFramework.java 8417394487a80b439e7d9897c83f0b2c1eb17ff4 src/examples/python/test_framework.py f436865b32c555a593e7cbb2c35b8cdae439932a src/examples/test_framework.cpp b9ab692414e4df64f176fc1ecd05f24ff089bde0 src/slave/constants.hpp ddf02570caf3793106b3c48e158a5bb48c1ae80c src/slave/constants.cpp 1735a6b55a93e6537a5a119e5345961f3d84a000 src/slave/slave.hpp bbba4404e9e2b1ff1e246f017cdad704438973ba src/slave/slave.cpp 28fd4c336d8ac658cf92811d20066a6cfdf5a95e src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503 src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392 src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6 src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 Diff: https://reviews.apache.org/r/8239/diff/ Testing ------- make check we will also be deploying this to a test cluster Thanks, Ben Mahler
