----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8239/ -----------------------------------------------------------
(Updated Dec. 6, 2012, 12:51 a.m.) Review request for mesos, Benjamin Hindman and Vinod Kone. Description ------- We were not validating executor resources, some executors would request 0 cpus and 0 memory. This would result in an OOM (if using the memory subsystem) or cpuset.cpus errors (if using the cpuset subsystem, we would write nothing to the cpuset.cpus file. This results in a write error: "No space left on device."). Diffs (updated) ----- src/examples/balloon_framework.cpp 35bc0fe712edbf6130e10e93286c5278625be096 src/examples/java/TestFramework.java 8417394487a80b439e7d9897c83f0b2c1eb17ff4 src/examples/python/test_framework.py f436865b32c555a593e7cbb2c35b8cdae439932a src/examples/test_framework.cpp b9ab692414e4df64f176fc1ecd05f24ff089bde0 src/slave/constants.hpp 464bf3f5752a3180031d3e88350fc92385eb7ee6 src/slave/constants.cpp PRE-CREATION src/slave/slave.hpp 032e1c26468d1bd7aaa204147b13545bb1384bd9 src/slave/slave.cpp 3d5a32cc51a5b8a5ff51c89da861ad1aeb0d7b33 src/tests/allocator_tests.cpp 44d72ad2b746b1b7032f8243817a6002100a7503 src/tests/allocator_zookeeper_tests.cpp 5f83dd71aa3cac1dd3727b65af087f651f961392 src/tests/fault_tolerance_tests.cpp 7c3d155479a4f7fda5c14f62909eea5f5a1a92df src/tests/master_tests.cpp 4e1232281e64226dbd24f2ca8d14aaa720003900 src/tests/resource_offers_tests.cpp 5981191597e673c47be331420b71be66456694c6 src/tests/utils.hpp cc1a81d07c6f23e3e2590c2df485f18d114cc6a6 Diff: https://reviews.apache.org/r/8239/diff/ Testing ------- make check we will also be deploying this to a test cluster Thanks, Ben Mahler
