----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8255/#review13837 -----------------------------------------------------------
Thanks for catching this! Glad to see it wasn't a bug in grow/shrink :) src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8255/#comment29569> Instead of printCpusets(): logCpusets()? But even better: LOG(INFO) << cpusetsState(); // where cpusetsState() returns the string. I'm seeing now that if we had Cpuset as a tree, this stuff could be a bit cleaner, but that's a bigger change so let's forget it for now. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8255/#comment29570> CHECK_NOT_NULL instead src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8255/#comment29568> Can you get this all in one log line? Meaning, build up a string and do one LOG call? Otherwise it will be a little tricky to read interspersed with other logging. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/8255/#comment29567> You need to store the result of the shrink and apply it to the cpus (similarly to how cpusetChanged() works). - Ben Mahler On Nov. 29, 2012, 12:02 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8255/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Tested by modifying balloon framework test to start the slave cpusets enabled. > > Will be writing more tests soon. > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 9f80fc5a969b959b34eaea4cac40700662d7f8b2 > src/slave/cgroups_isolation_module.cpp > 8211618d7729350654e2d17946c5b912ed9dda6a > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/8255/diff/ > > > Testing > ------- > > udo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter=*Cgroup* > > > Thanks, > > Vinod Kone > >
