> On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 940 > > <https://reviews.apache.org/r/8255/diff/1/?file=231391#file231391line940> > > > > You need to store the result of the shrink and apply it to the cpus > > (similarly to how cpusetChanged() works).
done > On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 707 > > <https://reviews.apache.org/r/8255/diff/1/?file=231391#file231391line707> > > > > Can you get this all in one log line? Meaning, build up a string and do > > one LOG call? > > > > Otherwise it will be a little tricky to read interspersed with other > > logging. done > On Nov. 29, 2012, 3:07 a.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 695 > > <https://reviews.apache.org/r/8255/diff/1/?file=231391#file231391line695> > > > > Instead of printCpusets(): logCpusets()? > > > > But even better: > > LOG(INFO) << cpusetsState(); // where cpusetsState() returns the string. > > > > I'm seeing now that if we had Cpuset as a tree, this stuff could be a > > bit cleaner, but that's a bigger change so let's forget it for now. sure. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8255/#review13837 ----------------------------------------------------------- On Nov. 29, 2012, 12:02 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8255/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 12:02 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Tested by modifying balloon framework test to start the slave cpusets enabled. > > Will be writing more tests soon. > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 9f80fc5a969b959b34eaea4cac40700662d7f8b2 > src/slave/cgroups_isolation_module.cpp > 8211618d7729350654e2d17946c5b912ed9dda6a > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/8255/diff/ > > > Testing > ------- > > udo GLOG_v=1 ./bin/mesos-tests.sh --verbose --gtest_filter=*Cgroup* > > > Thanks, > > Vinod Kone > >
