----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8284/#review13876 -----------------------------------------------------------
Ship it! src/slave/slave.cpp <https://reviews.apache.org/r/8284/#comment29660> How does having persistent state change things? (Maybe include that here too). src/slave/slave.cpp <https://reviews.apache.org/r/8284/#comment29661> It's fine that you've moved this down? - Ben Mahler On Nov. 29, 2012, 10:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8284/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is likely a short-term fix. > > Once we have persistent state in the master and slave, this might not be > necessary. > > > This addresses bug MESOS-152. > https://issues.apache.org/jira/browse/MESOS-152 > > > Diffs > ----- > > src/slave/slave.cpp 28fd4c336d8ac658cf92811d20066a6cfdf5a95e > src/tests/fault_tolerance_tests.cpp > 7c3d155479a4f7fda5c14f62909eea5f5a1a92df > > Diff: https://reviews.apache.org/r/8284/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
