> On Nov. 30, 2012, 12:14 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 853 > > <https://reviews.apache.org/r/8284/diff/1/?file=231701#file231701line853> > > > > How does having persistent state change things? (Maybe include that > > here too).
the idea is that master and slave together would know exactly what is running and in what state etc. since, we haven't completely implemented both the parts yet (registrar and slave restart) i'm reluctant to be more specific. i could just include the first sentence, but not sure its going to provide any better insight? > On Nov. 30, 2012, 12:14 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 874 > > <https://reviews.apache.org/r/8284/diff/1/?file=231701#file231701line874> > > > > It's fine that you've moved this down? yup. its more like i pushed the 'sending status message to master' part up. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8284/#review13876 ----------------------------------------------------------- On Nov. 29, 2012, 10:50 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8284/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 10:50 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > This is likely a short-term fix. > > Once we have persistent state in the master and slave, this might not be > necessary. > > > This addresses bug MESOS-152. > https://issues.apache.org/jira/browse/MESOS-152 > > > Diffs > ----- > > src/slave/slave.cpp 28fd4c336d8ac658cf92811d20066a6cfdf5a95e > src/tests/fault_tolerance_tests.cpp > 7c3d155479a4f7fda5c14f62909eea5f5a1a92df > > Diff: https://reviews.apache.org/r/8284/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
