> On Dec. 6, 2012, 6:58 p.m., Ben Mahler wrote: > > third_party/libprocess/include/stout/os.hpp, line 832 > > <https://reviews.apache.org/r/8171/diff/3/?file=231639#file231639line832> > > > > Hey vinod, since this review is related, can you include a fix of > > MESOS-318? > > > > It's a one liner.
It's definitely an issue on 32 bit systems: Ex: totalram: 995859 freeram: 34103 sharedram: 0 bufferram: 58425 totalswap: 3503615 freeswap: 3495360 procs: 895 totalhigh: 785282 freehigh: 3838 mem_unit: 4096 This will result in us interpreting the system as having 0.96 MB and since we use integers... 0 MB. - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8171/#review14100 ----------------------------------------------------------- On Nov. 29, 2012, 7:58 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8171/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2012, 7:58 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Now we properly set cpu/mem/disk/ports based on what's missing in slave flags. > > Also moved usage from os to fs. > > > Diffs > ----- > > src/slave/slave.cpp 7deb4574943aae4cfc5da5d6b3f600042686975f > src/tests/exception_tests.cpp 13355d08788432ed07679daf24c2d74cc12a7f11 > third_party/libprocess/include/stout/fs.hpp > 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d > third_party/libprocess/include/stout/os.hpp > 76e5e0624af36a0021755fb4acf7f76bfb81a823 > > Diff: https://reviews.apache.org/r/8171/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
