----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8171/#review15404 -----------------------------------------------------------
Ship it! Modulo comments. src/common/resources.hpp <https://reviews.apache.org/r/8171/#comment33173> Won't all these if's fit on one line? third_party/libprocess/include/stout/fs.hpp <https://reviews.apache.org/r/8171/#comment33175> This is my fault since I wrote usage() IIRC. Typically our os/fs messages are simply the strerror of the syscall. I guess in this case because "usage" uses "statvfs", it's not as obvious where the message originates. Maybe just: ::error("statvfs('" + fs + "'): " + sterrror(errno)); or ::error("statvfs: " + sterror(errno)); - Ben Mahler On Jan. 16, 2013, 6:53 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8171/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2013, 6:53 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Now we properly set cpu/mem/disk/ports based on what's missing in slave flags. > > Also moved usage from os to fs. > > > This addresses bug MESOS-318. > https://issues.apache.org/jira/browse/MESOS-318 > > > Diffs > ----- > > src/common/resources.hpp 5237b6031919aaed2d742bc095e537e83bf9f3fd > src/slave/slave.cpp 9755b46f97173d6fcc9ab1fd63e0e4814b3bc018 > src/tests/exception_tests.cpp 13355d08788432ed07679daf24c2d74cc12a7f11 > src/tests/resources_tests.cpp 83e93482a6800724d51aeae91e57d2a2b52b37b6 > third_party/libprocess/include/stout/fs.hpp > 9e62a1b91bc9fac092818ffb3c8bcec46b0bd26d > third_party/libprocess/include/stout/os.hpp > 76e5e0624af36a0021755fb4acf7f76bfb81a823 > > Diff: https://reviews.apache.org/r/8171/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
