-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8362/#review14180
-----------------------------------------------------------



src/examples/python/test_framework.py
<https://reviews.apache.org/r/8362/#comment30287>

    s/only//
    
    in this test, received cannot be less than sent can it?



src/python/src/mesos.py
<https://reviews.apache.org/r/8362/#comment30290>

    not yours, but can u kill ws



src/python/src/mesos.py
<https://reviews.apache.org/r/8362/#comment30291>

    ditto



src/python/src/mesos.py
<https://reviews.apache.org/r/8362/#comment30292>

    this doesn't match the signature in scheduler.hpp. wonder how it ever 
worked?



src/python/src/mesos.py
<https://reviews.apache.org/r/8362/#comment30289>

    this doesn't match the signature in executor.hpp?
    
    did you mean to change the signature for scheduler instead of executor?


- Vinod Kone


On Dec. 7, 2012, 8:21 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8362/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2012, 8:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> See MESOS-317.
> 
> 
> This addresses bug MESOS-317.
>     https://issues.apache.org/jira/browse/MESOS-317
> 
> 
> Diffs
> -----
> 
>   src/examples/python/test_executor.py 
> 0e38b1221dd7edc80b9e847663d6add6acc5a3f7 
>   src/examples/python/test_framework.py 
> f436865b32c555a593e7cbb2c35b8cdae439932a 
>   src/python/native/mesos_executor_driver_impl.cpp 
> cd4494cbdce9dd23101f15f6c5630404b4310f3e 
>   src/python/native/mesos_scheduler_driver_impl.cpp 
> 0fcbafa38650d80f2822e55983cd10550b1be2df 
>   src/python/native/proxy_executor.cpp 
> 343d42831046ac28bb1503d480b8679f5bc72b97 
>   src/python/native/proxy_scheduler.cpp 
> 53a8d57f288620acb21c82a982e8a87f5120af57 
>   src/python/src/mesos.py 39d37b8d6e9b41bc736df41a000a6347d4b189ef 
> 
> Diff: https://reviews.apache.org/r/8362/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to