> On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/examples/python/test_framework.py, line 112 > > <https://reviews.apache.org/r/8362/diff/3/?file=235865#file235865line112> > > > > s/only// > > > > in this test, received cannot be less than sent can it?
it was less with the null bug, but now it should match exactly > On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/python/src/mesos.py, line 34 > > <https://reviews.apache.org/r/8362/diff/3/?file=235870#file235870line34> > > > > this doesn't match the signature in scheduler.hpp. wonder how it ever > > worked? Dynamic type system combined with inadequate test coverage ;) > On Dec. 7, 2012, 8:33 p.m., Vinod Kone wrote: > > src/python/src/mesos.py, line 68 > > <https://reviews.apache.org/r/8362/diff/3/?file=235870#file235870line68> > > > > this doesn't match the signature in executor.hpp? > > > > did you mean to change the signature for scheduler instead of executor? Yep, thanks for catching that! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8362/#review14180 ----------------------------------------------------------- On Dec. 7, 2012, 8:21 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8362/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 8:21 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See MESOS-317. > > > This addresses bug MESOS-317. > https://issues.apache.org/jira/browse/MESOS-317 > > > Diffs > ----- > > src/examples/python/test_executor.py > 0e38b1221dd7edc80b9e847663d6add6acc5a3f7 > src/examples/python/test_framework.py > f436865b32c555a593e7cbb2c35b8cdae439932a > src/python/native/mesos_executor_driver_impl.cpp > cd4494cbdce9dd23101f15f6c5630404b4310f3e > src/python/native/mesos_scheduler_driver_impl.cpp > 0fcbafa38650d80f2822e55983cd10550b1be2df > src/python/native/proxy_executor.cpp > 343d42831046ac28bb1503d480b8679f5bc72b97 > src/python/native/proxy_scheduler.cpp > 53a8d57f288620acb21c82a982e8a87f5120af57 > src/python/src/mesos.py 39d37b8d6e9b41bc736df41a000a6347d4b189ef > > Diff: https://reviews.apache.org/r/8362/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
