----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8423/#review14334 -----------------------------------------------------------
third_party/libprocess/include/stout/protobuf.hpp <https://reviews.apache.org/r/8423/#comment30521> As you mention, if this is an EINTR then we can retry, so feel free to add a TODO to do this at some point. third_party/libprocess/include/stout/protobuf.hpp <https://reviews.apache.org/r/8423/#comment30520> I think casting the unsigned thing to a signed thing instead of possibly lossing the signded'ness might be the better approach. - Benjamin Hindman On Dec. 7, 2012, 10:54 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8423/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2012, 10:54 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > The following error was reported on the mailing list: > > This is off of trunk; gcc version is 4.6.2. > > Error message is "In function protobuf.hpp in function 'Result<bool> > protobuf::read(int, google::protobuf::Message*)': ... protobuf.hpp:131:24: > Comparison between signed and unsigned integer expressions > [-Werror=signed-compare]" > > > Diffs > ----- > > third_party/libprocess/include/stout/protobuf.hpp > d2b5daedb878fcf04bc38ba912ffc0ca9a930729 > > Diff: https://reviews.apache.org/r/8423/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
