-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8423/
-----------------------------------------------------------

(Updated Dec. 12, 2012, 7:55 p.m.)


Review request for mesos, Benjamin Hindman and Vinod Kone.


Changes
-------

Added TODOs to fix buggy reads/writes.
Changed the cast.


Description
-------

The following error was reported on the mailing list:

This is off of trunk; gcc version is 4.6.2.

Error message is "In function protobuf.hpp in function 'Result<bool> 
protobuf::read(int, google::protobuf::Message*)': ... protobuf.hpp:131:24: 
Comparison between signed and unsigned integer expressions 
[-Werror=signed-compare]"


Diffs (updated)
-----

  third_party/libprocess/include/stout/os.hpp 
76e5e0624af36a0021755fb4acf7f76bfb81a823 
  third_party/libprocess/include/stout/protobuf.hpp 
d2b5daedb878fcf04bc38ba912ffc0ca9a930729 

Diff: https://reviews.apache.org/r/8423/diff/


Testing
-------

make check


Thanks,

Ben Mahler

Reply via email to