----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8797/#review15043 -----------------------------------------------------------
third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32589> isn't ANY the default? third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32590> it is confusing to use the variable 'encodings' for acceptable encodings, when the requested encoding is called 'encoding'. third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32596> how is the * matched? third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32591> for eg, this would be easier to grok if you did foreach(std::string& encoding, encodings) third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32594> when is "values["q"].size() != 1" possible? third_party/libprocess/src/encoder.hpp <https://reviews.apache.org/r/8797/#comment32595> can the 'q' value be negative? third_party/libprocess/src/process.cpp <https://reviews.apache.org/r/8797/#comment32598> From the above, it sounds like 'request' should contain the information about 'persist'? if so, isnt this redundant? - Vinod Kone On Jan. 2, 2013, 2:54 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8797/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2013, 2:54 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See bug description. > > > This addresses bug MESOS-309. > https://issues.apache.org/jira/browse/MESOS-309 > > > Diffs > ----- > > third_party/libprocess/src/encoder.hpp > 9664f38b7b972f196921ef13adb8c9caa180ca65 > third_party/libprocess/src/process.cpp > 72e437862ee0b35126c16d32bec79ef76a4e2b23 > > Diff: https://reviews.apache.org/r/8797/diff/ > > > Testing > ------- > > make check (also added some tests in the following reviews). > > > Thanks, > > Ben Mahler > >
