> On March 5, 2013, 9:46 a.m., Benjamin Hindman wrote: > > third_party/libprocess/include/process/http.hpp, line 75 > > <https://reviews.apache.org/r/8797/diff/5/?file=264506#file264506line75> > > > > Again, just a naming thing, but I find 'strings::startsWith(encoding, > > candidate)' better as I read it aloud as "does encoding start with > > candidate?" which sounds quite natural. I understand that encoding is > > already used here, so feel free to ignore.
Yeah.. I noticed this as well but punted since encoding was already used, went with _encoding since I really like the readability of using "encoding". > On March 5, 2013, 9:46 a.m., Benjamin Hindman wrote: > > third_party/libprocess/src/process.cpp, line 1583 > > <https://reviews.apache.org/r/8797/diff/5/?file=264508#file264508line1583> > > > > See my comment below about not needing to pass the 'persist' parameter. > > For this case, I suggest creating an HttpResponseEncoder directly so that > > you can force the persistance of the socket. That is, it could be that the > > request doesn't have keep-alive, in fact, it could be that the request > > asked to close the connection after the data is returned. But since we're > > going to sendfile the data still we don't want to close the socket yet. Ok, fixed. Please take a look! - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8797/#review17393 ----------------------------------------------------------- On March 2, 2013, 9:38 p.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8797/ > ----------------------------------------------------------- > > (Updated March 2, 2013, 9:38 p.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See bug description. > > > This addresses bug MESOS-309. > https://issues.apache.org/jira/browse/MESOS-309 > > > Diffs > ----- > > third_party/libprocess/include/process/http.hpp > bc397e6f1d539d621b85d7ab36afb0237ceefca9 > third_party/libprocess/src/encoder.hpp > 9664f38b7b972f196921ef13adb8c9caa180ca65 > third_party/libprocess/src/process.cpp > 8ae20b5d9ffc415e36e076ed78842aae7ddd4314 > > Diff: https://reviews.apache.org/r/8797/diff/ > > > Testing > ------- > > make check (also added some tests in the following reviews). > > > Thanks, > > Ben Mahler > >
