----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9305/#review16090 -----------------------------------------------------------
src/logging/logging.cpp <https://reviews.apache.org/r/9305/#comment34410> severity is typedef'ed to an int. Should we guard against negative values too? src/logging/logging.cpp <https://reviews.apache.org/r/9305/#comment34411> Is it safe to assume that you are going to update this in your "Refactored all Try<T>::error and Result<T>::error to use Error or ErrnoError" changeset? - Rob Benson On Feb. 5, 2013, 5:57 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9305/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2013, 5:57 a.m.) > > > Review request for mesos and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp e9d778f840f2d6713dbb99d0a8844033be9f0e5f > > Diff: https://reviews.apache.org/r/9305/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
