> On Feb. 5, 2013, 7:49 a.m., Rob Benson wrote: > > src/logging/logging.cpp, line 211 > > <https://reviews.apache.org/r/9305/diff/1/?file=255492#file255492line211> > > > > severity is typedef'ed to an int. Should we guard against negative > > values too?
Boom! Good catch sir. And this, good people of the Internet, is why we don't (read: rarely) use typedefs. > On Feb. 5, 2013, 7:49 a.m., Rob Benson wrote: > > src/logging/logging.cpp, line 212 > > <https://reviews.apache.org/r/9305/diff/1/?file=255492#file255492line212> > > > > Is it safe to assume that you are going to update this in your > > "Refactored all Try<T>::error and Result<T>::error to use Error or > > ErrnoError" changeset? Come on now ... ;) - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9305/#review16090 ----------------------------------------------------------- On Feb. 8, 2013, 5:49 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9305/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2013, 5:49 a.m.) > > > Review request for mesos and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/logging/logging.cpp e9d778f840f2d6713dbb99d0a8844033be9f0e5f > > Diff: https://reviews.apache.org/r/9305/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
