> On Jan. 16, 2013, 11:07 p.m., Ben Mahler wrote: > > src/slave/reaper.hpp, line 47 > > <https://reviews.apache.org/r/8570/diff/3/?file=249260#file249260line47> > > > > Are you able to programmatically enforce that one of these holds? > > Vinod Kone wrote: > not easily, no. esp. 1 and 2, in posix compliant way. > > more importantly, what do you mean by "enforce"? what do you propose we > do when one of those 3 conditions aren't satisfied? log a warning?
Well what is the consequence of none of these being satisfied, and consequently, the notification not being sent? > On Jan. 16, 2013, 11:07 p.m., Ben Mahler wrote: > > src/slave/reaper.hpp, line 51 > > <https://reviews.apache.org/r/8570/diff/3/?file=249260#file249260line51> > > > > I think this is more succinct without losing clarity: > > s/addProcess/monitor > > Vinod Kone wrote: > I like addProcess because of its similarity to addListener. But, I could > be convinced otherwise. > On Jan. 16, 2013, 11:07 p.m., Ben Mahler wrote: > > src/slave/reaper.cpp, line 96 > > <https://reviews.apache.org/r/8570/diff/3/?file=249261#file249261line96> > > > > But what about condition 3 you listed, where we are a privileged user? > > Vinod Kone wrote: > Then we souldn't enter this if loop. Can you add a comment as to why? - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8570/#review15415 ----------------------------------------------------------- On Jan. 24, 2013, 12:17 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8570/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2013, 12:17 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > Needed this to properly monitor the exit status of re-connected executors, as > they will be parented by INIT. > > > Diffs > ----- > > src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0 > src/linux/proc.hpp e0825a4a9f9e2763e0c25d7319f220bfe7c7c29c > src/linux/proc.cpp 8a0fc48dc9769df35d682ece477246b2df2fc0d4 > src/sched/sched.cpp f1eeab6f12ee300d77013c6a4ba62ccd7fdb0d1d > src/slave/cgroups_isolation_module.cpp > 63cefc33cf34eebb82db5d8448b751be8652fa36 > src/slave/lxc_isolation_module.cpp 30cff2a49339bb07030727d30352536a0a22d58c > src/slave/process_based_isolation_module.cpp > 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 > src/slave/reaper.hpp b9aa62daa42bdaa736ade43884982529ba3d4bb1 > src/slave/reaper.cpp c0ee4b4c07fd792bcb39455b666808b712eb32c2 > src/slave/solaris_project_isolation_module.cpp > f3b6a68926af34c46873d8de1c9858480f42ef98 > src/tests/cgroups_tests.cpp b219906374764e91f1a5268469ae92dd0fe08e53 > src/tests/master_tests.cpp 948ab5dff34eeba1f3ce593a864ddf282c8b19ed > src/tests/process_spawn.cpp 04e836f8eed7312dbee27e20399e7d0e59df0bc2 > src/tests/reaper_tests.cpp PRE-CREATION > src/tests/script.cpp ebd2ab52e4de2dac744712b5adb1107a33ed29df > src/tests/utils.hpp be457117515ee727af101370b26bf9188afb8f45 > third_party/libprocess/Makefile.am 11f8b36d19313f65f1b191a781c6d5ed90130099 > third_party/libprocess/include/stout/proc.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/8570/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
