> On Feb. 15, 2013, 11:17 p.m., Ben Mahler wrote: > > src/slave/cgroups_isolation_module.cpp, line 80 > > <https://reviews.apache.org/r/9464/diff/1/?file=258974#file258974line80> > > > > Is there any way to pull the period from a linux header? Will the > > bandwidth control contain this value initially, or -1? > > > > Do you see the default ever changing?
It will likely never change. The process to change a default like this is much too contentious and political for anyone to try. Sadly, this is defined fairly deep in the kernel and is not exposed. The period is set to 100ms on boot so it technically doesn't need to be "initialized" by this code if it is to remain at that value. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9464/#review16667 ----------------------------------------------------------- On Feb. 18, 2013, 11:51 p.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9464/ > ----------------------------------------------------------- > > (Updated Feb. 18, 2013, 11:51 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups. > > CFS is unique relative to existing Mesos cgroups support in that it is a > "subfeature" of an already supported cgroups subsystem, cpu. Also, there are > two "tunables" for configuring CFS bandwidth limiting. > > There are 4 approaches one could take: > 1) Use the CFS bandwidth limiting if the feature is present > 2) Expose as separate flag, eg "cpu,cfs,memory,freezer" > 3) Add feature flag support to subsystems via an additional delimiter, eg > "cpu+cfs,memory,freezer". > 4) Add an additional control flag via some other means > > Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a > cgroups resource flag. > Option 3's downside is it greatly increases complexity of parsing cgroups > subsystem flags. > > This diff takes option 1. > > > This addresses bug MESOS-315. > https://issues.apache.org/jira/browse/MESOS-315 > > > Diffs > ----- > > src/slave/cgroups_isolation_module.cpp 14f549e > > Diff: https://reviews.apache.org/r/9464/diff/ > > > Testing > ------- > > make check + additional testing > > > Thanks, > > David Mackey > >
