----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9464/#review17274 -----------------------------------------------------------
src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9464/#comment36738> period at the end. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9464/#comment36739> s/, your/. Your/ ? src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9464/#comment36740> quotes around cfsChanged. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9464/#comment36743> Considering mesos is responsible for manipulating resources, this should be a CHECK. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9464/#comment36744> Move these down to where they are used (line #815) - Vinod Kone On March 1, 2013, 9:24 p.m., David Mackey wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9464/ > ----------------------------------------------------------- > > (Updated March 1, 2013, 9:24 p.m.) > > > Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler. > > > Description > ------- > > Initial support for CPU "hard limits" via CFS Bandwidth Control in cgroups. > > CFS is unique relative to existing Mesos cgroups support in that it is a > "subfeature" of an already supported cgroups subsystem, cpu. Also, there are > two "tunables" for configuring CFS bandwidth limiting. > > There are 4 approaches one could take: > 1) Use the CFS bandwidth limiting if the feature is present > 2) Expose as separate flag, eg "cpu,cfs,memory,freezer" > 3) Add feature flag support to subsystems via an additional delimiter, eg > "cpu+cfs,memory,freezer". > 4) Add an additional control flag via some other means > > Option 2's downside breaks the 1:1 mapping between cgroups subsystems and a > cgroups resource flag. > Option 3's downside is it greatly increases complexity of parsing cgroups > subsystem flags. > > This diff takes option 1. > > > This addresses bug MESOS-315. > https://issues.apache.org/jira/browse/MESOS-315 > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp a04fc46 > src/slave/cgroups_isolation_module.cpp a779de8 > src/slave/flags.hpp d4aa045 > > Diff: https://reviews.apache.org/r/9464/diff/ > > > Testing > ------- > > make check + additional testing > > > Thanks, > > David Mackey > >
