----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9093/#review16812 -----------------------------------------------------------
Ship it! third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment35722> Old habits die hard. Kill them more quickly. third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment35724> s/data/values/ third_party/libprocess/src/statistics.cpp <https://reviews.apache.org/r/9093/#comment35725> const. - Benjamin Hindman On Feb. 13, 2013, 2:12 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9093/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 2:12 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Some statistics will be ephemeral. (e.g. executor resource usage information). > It does not make sense to keep a value of these stats in the snapshot. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > third_party/libprocess/include/process/clock.hpp > 1a98c6a8b50fdad5308321413121f86bea135d37 > third_party/libprocess/include/process/statistics.hpp > 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 > third_party/libprocess/src/statistics.cpp > 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f > third_party/libprocess/src/tests/statistics_tests.cpp > 0aaab3526618171c7cfbd11d40d614344bcbfd0a > > Diff: https://reviews.apache.org/r/9093/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
