-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9093/#review15815
-----------------------------------------------------------



third_party/libprocess/src/statistics.cpp
<https://reviews.apache.org/r/9093/#comment34066>

    Why are these virtual?



third_party/libprocess/src/statistics.cpp
<https://reviews.apache.org/r/9093/#comment34067>

    s/perpetually based on/periodically every/ ?


- Vinod Kone


On Jan. 29, 2013, 12:45 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9093/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 12:45 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Some statistics will be ephemeral. (e.g. executor resource usage information).
> It does not make sense to keep a value of these stats in the snapshot.
> 
> 
> This addresses bug MESOS-324.
>     https://issues.apache.org/jira/browse/MESOS-324
> 
> 
> Diffs
> -----
> 
>   third_party/libprocess/include/process/statistics.hpp 
> 9e3041a6e2a8ef022eacacad00bc4d974a8e33c9 
>   third_party/libprocess/src/statistics.cpp 
> 2fe8af83c6c63a0fa8cb2e9636f9289f0e3d7f2f 
> 
> Diff: https://reviews.apache.org/r/9093/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>

Reply via email to