----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9147/#review16822 -----------------------------------------------------------
Ship it! src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9147/#comment35738> No need for temporary. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9147/#comment35737> Kill newline. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9147/#comment35739> Looking at libtop.c makes me think this is just '!= 0'. - Benjamin Hindman On Feb. 13, 2013, 2:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9147/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 2:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Implements process based isolation resource collection for OSX. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp > 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 > > Diff: https://reviews.apache.org/r/9147/diff/ > > > Testing > ------- > > End-to-end tests via webui. > > > Thanks, > > Ben Mahler > >
