> On Feb. 21, 2013, 2:04 a.m., Benjamin Hindman wrote: > > src/slave/process_based_isolation_module.cpp, line 328 > > <https://reviews.apache.org/r/9147/diff/3/?file=258503#file258503line328> > > > > Looking at libtop.c makes me think this is just '!= 0'.
I disagree! 1. http://code.google.com/p/psutil/source/browse/branches/sunos/psutil/arch/osx/process_info.c?spec=svn1517&r=1517 2. http://www.opensource.apple.com/source/xnu/xnu-1456.1.26/bsd/kern/proc_info.c 3. http://code.google.com/p/macfuse/source/browse/trunk/filesystems/procfs/procfs_proc_info.cc - Ben ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9147/#review16822 ----------------------------------------------------------- On Feb. 13, 2013, 2:58 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9147/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2013, 2:58 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Implements process based isolation resource collection for OSX. > > > This addresses bug MESOS-324. > https://issues.apache.org/jira/browse/MESOS-324 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp > 3d50a4b652e4e09dd57e744e408c8fb79ff3fbf5 > > Diff: https://reviews.apache.org/r/9147/diff/ > > > Testing > ------- > > End-to-end tests via webui. > > > Thanks, > > Ben Mahler > >
