----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9636/#review17125 -----------------------------------------------------------
Ship it! src/tests/monitor_tests.cpp <https://reviews.apache.org/r/9636/#comment36275> !? src/tests/monitor_tests.cpp <https://reviews.apache.org/r/9636/#comment36277> Don't even need the temporary if you don't want it. src/tests/monitor_tests.cpp <https://reviews.apache.org/r/9636/#comment36270> Seems like you should pull out an 'interval' variable rather than put 'Seconds(5)' everywhere to make the test less brittle. src/tests/monitor_tests.cpp <https://reviews.apache.org/r/9636/#comment36268> I'm fine to have you expose the pid (we've done this in a few other places too) but you also can construct this PID very easily (since you know it's ID and can get the IP/port as well). - Benjamin Hindman On Feb. 27, 2013, 1:08 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9636/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 1:08 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Ultimately I'd like to be testing even more functionality of the > ResourceMonitor: > 1. Check that the data has been published to statistics. > 2. Check that metering is occurring on subsequent resource data (cpu_usage). > 3. Add tests for process based isolation usage. > 4. Add tests for cgroups based isolation usage. > > 1 and 2 are possible within this change. > 3 and 4 are trickier given our current testing setup. > > For now, I've done testing locally and a test cluster to ensure the above > were working as intended. > > > Diffs > ----- > > src/Makefile.am 8c74525ff6381b6d8624622a758b792fd631cd8c > src/slave/monitor.hpp e2ef3bdf6cd5b2718db01184d98d4d29cd5b00c9 > src/slave/monitor.cpp 16a555c15014bd964003be0666908ae1720bf1fc > src/tests/monitor_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/9636/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
