> On Feb. 27, 2013, 1:32 a.m., Benjamin Hindman wrote: > > src/tests/monitor_tests.cpp, line 93 > > <https://reviews.apache.org/r/9636/diff/2/?file=262939#file262939line93> > > > > I'm fine to have you expose the pid (we've done this in a few other > > places too) but you also can construct this PID very easily (since you know > > it's ID and can get the IP/port as well). > > Ben Mahler wrote: > Ah yes I wanted to do that, but missed the process::ip and process::port > calls! > > I will change http::get to take a UPID instead as well, but I thought I > recalled an aversion to that on your part?
UPID is just deprecated in libprocess. We'll eventually replace everything with PID<> ... it's just going to take a while. > On Feb. 27, 2013, 1:32 a.m., Benjamin Hindman wrote: > > src/tests/monitor_tests.cpp, line 78 > > <https://reviews.apache.org/r/9636/diff/2/?file=262939#file262939line78> > > > > Don't even need the temporary if you don't want it. > > Ben Mahler wrote: > Couldn't get it to compile used inline without the temporary. Wow, really? What was the error? That's surprising ... to me, but no worries. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9636/#review17125 ----------------------------------------------------------- On Feb. 27, 2013, 2:16 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9636/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2013, 2:16 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > Ultimately I'd like to be testing even more functionality of the > ResourceMonitor: > 1. Check that the data has been published to statistics. > 2. Check that metering is occurring on subsequent resource data (cpu_usage). > 3. Add tests for process based isolation usage. > 4. Add tests for cgroups based isolation usage. > > 1 and 2 are possible within this change. > 3 and 4 are trickier given our current testing setup. > > For now, I've done testing locally and a test cluster to ensure the above > were working as intended. > > > Diffs > ----- > > src/Makefile.am 8c74525ff6381b6d8624622a758b792fd631cd8c > src/files/files.hpp ff12c0dc70af107397c499ec605691a8367d0c90 > src/files/files.cpp 29705dc69921a86a0abd7428f2c5d38c41838301 > src/slave/monitor.hpp e2ef3bdf6cd5b2718db01184d98d4d29cd5b00c9 > src/tests/files_tests.cpp 7147b9a6a16a63fe7922bd84bda0539f89c00f5c > src/tests/gc_tests.cpp 411bcc09b28a2543ecd3d083839e10844e8a9939 > src/tests/monitor_tests.cpp PRE-CREATION > third_party/libprocess/include/process/http.hpp > bee67826485fd77591621af74437bf38c8ce83e1 > third_party/libprocess/src/process.cpp > ede0e5563d0811ad661f78072a862b21473763f3 > > Diff: https://reviews.apache.org/r/9636/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Ben Mahler > >
