----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review17159 -----------------------------------------------------------
Ship it! src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment36337> Might consider moving this above the destroy call (consider setting it to indicate the "intent"). Given the semantics of libprocess and onAny, and defer, you should be safe, but it's probably better practice to assume you've passed ownership of variables and that you can no longer manipulate them. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment36338> It also gets printed in the slave ... - Benjamin Hindman On Feb. 26, 2013, 12:32 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 26, 2013, 12:32 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > a04fc46b15d2741886f5847cadbdc9bed351c588 > src/slave/cgroups_isolation_module.cpp > a779de80d13c67e507d7d2ee788fcdaa5e71daca > src/slave/slave.hpp 7648c33230c1900eda7529045c5df9ccab105d47 > src/slave/slave.cpp 8c2e1bfc363491c681177676f9dfe5f229276f7d > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
