----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9408/#review16989 -----------------------------------------------------------
Ship it! src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment35989> Yup, I missed this. An option is probably better. src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment35990> Can't, since _killExecutor gets used above as well for cleaning up cgroups on startup. Probably means we need two different continuations here, the _killExecutor continuation and the one for just cleaning up the cgroup. Then we don't need to do the Option<CgroupInfo> business or the CHECK to make sure the cgroup name is the same as the info->name()! src/slave/cgroups_isolation_module.cpp <https://reviews.apache.org/r/9408/#comment35991> Right, so it's probably fine for now. But we could consider waiting for BOTH the processTerminated event AND the cgroup destroyed event. Futures give us this power! Oh darn, if only the reaper gave us a future instead! How about we add a todo here that says we should actually wait for both events ONCE the reaper returns a future instead. - Benjamin Hindman On Feb. 22, 2013, 2:49 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9408/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2013, 2:49 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary > > > Diffs > ----- > > src/slave/cgroups_isolation_module.hpp > 669efa14ba2603764aa68ae19a44e79dbfdec192 > src/slave/cgroups_isolation_module.cpp > a2eba6f96f5d8a4b1257571aa29e37c5682aab8d > src/slave/process_based_isolation_module.cpp > 12a579cba56cd3dac384bc7919b0d5537b0e429d > src/slave/slave.cpp d4721c3eb51db87278d05f6fbe2eadb8a3a9b4dd > src/tests/balloon_framework_test.sh > 93a733f64cfde08349b7781eb3d5e13594c74498 > > Diff: https://reviews.apache.org/r/9408/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
