----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9723/#review17341 -----------------------------------------------------------
Thanks! I think we should have the source field express the semantics behind why we're launching the executor (as in my comments below). src/common/type_utils.hpp <https://reviews.apache.org/r/9723/#comment36849> can you compare the framework id as well, if present? src/examples/balloon_framework.cpp <https://reviews.apache.org/r/9723/#comment36843> I think this is misleading, let's call the source: "balloon_test" src/examples/java/TestFramework.java <https://reviews.apache.org/r/9723/#comment36846> Ditto, can you name the source "java_test" or the like? src/examples/python/test_framework.py <https://reviews.apache.org/r/9723/#comment36847> "python_test"? src/examples/test_framework.cpp <https://reviews.apache.org/r/9723/#comment36848> "cpp_test"? - Ben Mahler On March 3, 2013, 9:43 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9723/ > ----------------------------------------------------------- > > (Updated March 3, 2013, 9:43 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/examples/balloon_framework.cpp 78f03b69147367844bbd2c3762574aa6f11e670b > src/examples/java/TestFramework.java > dc892c7a6444d2940839529072258e151ea84d83 > src/examples/python/test_framework.py > bba1f508fdcff050c653f4b9de472a197ab8bb9f > src/examples/test_framework.cpp dd2dd575ec7287a922d7a7c9b4cc0e62c2e29e0e > > Diff: https://reviews.apache.org/r/9723/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Vinod Kone > >
