----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9723/#review17346 -----------------------------------------------------------
Ship it! Modulo the source id's. I think they should be idiomatic examples of identifiers, i.e. lowercase, underscores, no strange characters (+) src/examples/balloon_framework.cpp <https://reviews.apache.org/r/9723/#comment36852> Given people might look at these examples, these files are advocating to framework designers on how to name the source field. So can we name them as "balloon_test"? That is, lower case, no strange characters, and underscores instead of dashes? src/examples/java/TestFramework.java <https://reviews.apache.org/r/9723/#comment36854> Lowercase? java_test src/examples/python/test_framework.py <https://reviews.apache.org/r/9723/#comment36855> lowercase? python_test src/examples/test_framework.cpp <https://reviews.apache.org/r/9723/#comment36853> once we start validating identifier characters, we might be excluding '+' so for this one I think "cpp_test" is more idiomatic - Ben Mahler On March 4, 2013, 6:57 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9723/ > ----------------------------------------------------------- > > (Updated March 4, 2013, 6:57 p.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/common/type_utils.hpp fde69aeec403b3455839dca6b0b2e1507d81ba00 > src/examples/balloon_framework.cpp 78f03b69147367844bbd2c3762574aa6f11e670b > src/examples/java/TestFramework.java > dc892c7a6444d2940839529072258e151ea84d83 > src/examples/python/test_framework.py > bba1f508fdcff050c653f4b9de472a197ab8bb9f > src/examples/test_framework.cpp dd2dd575ec7287a922d7a7c9b4cc0e62c2e29e0e > > Diff: https://reviews.apache.org/r/9723/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Vinod Kone > >
