----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9795/#review17556 -----------------------------------------------------------
src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37217> +1 pull this up to where pageSize is initialized. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37220> s/children/descendants/ src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37218> i usually like to put ": " on the same line as error. but upto you. src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37219> s/all the child process usage/the usage of all child processes/ src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37221> umm..i definitely prefer ancestor to parent! src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37222> I think it makes more sense to return an error here instead of returning a wrong value to the user! src/slave/process_based_isolation_module.cpp <https://reviews.apache.org/r/9795/#comment37223> ditto. - Vinod Kone On March 7, 2013, 3:18 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9795/ > ----------------------------------------------------------- > > (Updated March 7, 2013, 3:18 a.m.) > > > Review request for mesos, Benjamin Hindman and Vinod Kone. > > > Description > ------- > > See subject. > > > This addresses bug MESOS-370. > https://issues.apache.org/jira/browse/MESOS-370 > > > Diffs > ----- > > src/slave/process_based_isolation_module.cpp > ff98d105af675dfc66070feaa43b42c1aa438fd8 > > Diff: https://reviews.apache.org/r/9795/diff/ > > > Testing > ------- > > make check and added tests in a subsequent review > > > Thanks, > > Ben Mahler > >
